-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making examples work out-of-the-box #224
base: develop
Are you sure you want to change the base?
Conversation
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @caffeinum
Thanks for this pull request.
I left you some comments and it looks like you introduced dotenv
but it is not in the npm dependency list. Please add it as dev dependency for the examples to work.
Additionally, I suggest you either create an .env.example
or another way to document the ENV variables you introduce with this pull request
// Through pinning the metadata in IPFS, we can get the IPFS URI. You can read more about it here: https://docs.ipfs.tech/how-to/pin-files/ | ||
// const metadataUri = await client.methods.pinMetadata(metadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the intention with this comment? the code is already on lines 37-38
context.network | ||
); | ||
|
||
// console.log('tokenVotingInstallItem', tokenVotingInstallItem); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove or uncomment
}); | ||
break; | ||
const createDaoParams: CreateDaoParams = { | ||
metadataUri, // : `https://dao.mydao.com/metadata.json`, // the URI of the metadata file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the URL is more like ipfs://QmXhxqAneHFWr98Jqv96Pzm8pysfiLMcoyAuf8BQq6DK6m
when you use the IPFS upload. Otherwise it can be any kind of URL
SDK Examples Quickstart
Running these sdk examples, I have fallen into many small hurdles. I would love these examples to be easy to get up and running in 5 minutes.
I have started with fixing the config to work without any additional modification from the user
Task: ID
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and before the latest version.